Removing unreachable code #15281
Merged
Removing unreachable code #15281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run fantomas |
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
|
Wait, so regarding 1st point, I would assume there's a bug in Windows 7 and 8 (plus?) because it was supposed to be an |
|
This PR is only removing unreachable code. ( |
|
This is a good change. |
KevinRansom
approved these changes
May 31, 2023
abonie
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isWindows7 && (IntPtr.Size = 8) && isWindows8Pluscould never be true - Windows cannot have two versions at the same time. Removing all dead code related to that.No longer necessary parameter for FsiEvaluationSession.ReportUnhandledExceptionSafe kept in order to keep this public type compatible.
2.
UnmanagedProcessExecutionOptions.EnableHeapTerminationOnCorruptiononly did anything in cases whereEnvironment.Version.Major < 3. This reflects the CLR version, applies to .NET Framework 3.5 or lower - the compiler no longer targets that.